Stream: git-wasmtime

Topic: wasmtime / PR #8810 Cranelift: Traps need not be consider...

Wasmtime GitHub notifications bot (Jun 14 2024 at 19:43):

fitzgen opened PR #8810 from fitzgen:traps-are-not-safepoints to bytecodealliance:main:

After https://github.com/bytecodealliance/wasmtime/pull/8809, the mutator cannot resume from a trap so we don't need to consider them safepoints, as no GC-managed references are live after the trap. The one exception being the debugtrap CLIF instruction, which is technically still a resumable trap, but which exists only for emitting the equivalent of an int3 breakpoint instruction for pausing in a debugger to inspect state, and should never be used for mutator-collector interactions.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 14 2024 at 19:43):

fitzgen requested cfallin for a review on PR #8810.

Wasmtime GitHub notifications bot (Jun 14 2024 at 19:43):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #8810.

Wasmtime GitHub notifications bot (Jun 14 2024 at 19:45):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 14 2024 at 20:10):

fitzgen merged PR #8810.

Last updated: Dec 23 2024 at 12:05 UTC