Wasmtime GitHub notifications bot (Jun 14 2024 at 19:13): Wasmtime GitHub notifications bot (Jun 14 2024 at 19:13):fitzgen opened PR #8809 from fitzgen:no-more-resumable-traps to bytecodealliance:main:
These were originally a SpiderMonkey-ism and have been unused ever since. It was introduced for GC integration, where the runtime could do something to make Cranelift code hit a trap and pause for a GC and then resume execution once GC completed. But it is unclear that, as implemented, this is actually a useful mechanism for doing that (compared to, say, loading from some Well Known page and the GC protecting that page and catching signals to interrupt the mutator, or simply branching and doing a libcall). And if someone has that particular use case in the future (Wasmtime and its GC integration doesn't need exactly this) then we can design something for what is actually needed at that time, instead of carrying this cruft forward forever.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 14 2024 at 19:13):fitzgen requested alexcrichton for a review on PR #8809.
Wasmtime GitHub notifications bot (Jun 14 2024 at 19:13):fitzgen requested wasmtime-fuzz-reviewers for a review on PR #8809.
Wasmtime GitHub notifications bot (Jun 14 2024 at 19:13):fitzgen requested abrown for a review on PR #8809.
Wasmtime GitHub notifications bot (Jun 14 2024 at 19:13):fitzgen requested wasmtime-compiler-reviewers for a review on PR #8809.
Wasmtime GitHub notifications bot (Jun 14 2024 at 19:21):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jun 14 2024 at 19:25):fitzgen has enabled auto merge for PR #8809.
Wasmtime GitHub notifications bot (Jun 14 2024 at 19:39):fitzgen merged PR #8809.
Last updated: Nov 22 2024 at 17:03 UTC