Stream: git-wasmtime

Topic: wasmtime / PR #8808 Disable `call-hook` crate feature by ...

Wasmtime GitHub notifications bot (Jun 14 2024 at 18:21):

alexcrichton opened PR #8808 from alexcrichton:call-hook-off-by-default to bytecodealliance:main:

This commit disables the call-hook feature for the Wasmtime crate added in #8795 by default. The rationale is that this has a slight cost to all embeddings even if the feature isn't used and it's not expected to be that widely used of a feature, so off-by-default seems like a more appropriate default.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 14 2024 at 18:21):

alexcrichton requested elliottt for a review on PR #8808.

Wasmtime GitHub notifications bot (Jun 14 2024 at 18:21):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8808.

Wasmtime GitHub notifications bot (Jun 14 2024 at 18:21):

alexcrichton requested wasmtime-default-reviewers for a review on PR #8808.

Wasmtime GitHub notifications bot (Jun 14 2024 at 19:45):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jun 14 2024 at 20:09):

alexcrichton updated PR #8808.

Wasmtime GitHub notifications bot (Jun 14 2024 at 20:09):

alexcrichton has enabled auto merge for PR #8808.

Wasmtime GitHub notifications bot (Jun 14 2024 at 20:33):

alexcrichton updated PR #8808.

Wasmtime GitHub notifications bot (Jun 14 2024 at 20:33):

alexcrichton has enabled auto merge for PR #8808.

Wasmtime GitHub notifications bot (Jun 14 2024 at 20:56):

alexcrichton merged PR #8808.

Last updated: Nov 22 2024 at 17:03 UTC