Stream: git-wasmtime

Topic: wasmtime / PR #8806 Const-propagate some offsets in `VMOf...

Wasmtime GitHub notifications bot (Jun 14 2024 at 17:35):

alexcrichton opened PR #8806 from alexcrichton:more-const-propagate to bytecodealliance:main:

Before this commit all offsets to all fields in VMOffsets were stored as fields within VMOffset itself. All of the fields at the start of VMOffsets, however, are statically known given the pointer size. Notably this means that the use of HostPtr in the runtime still was forcing a dynamic lookup of these static offsets.

This commit refactors this to reflect all static offsets based solely on the pointer size in the PtrSize trait, removing all the fields from VMOffsets. All the dynamically sized fields, however, remain in VMOffsets.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 14 2024 at 17:35):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #8806.

Wasmtime GitHub notifications bot (Jun 14 2024 at 17:35):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8806.

Wasmtime GitHub notifications bot (Jun 14 2024 at 17:35):

alexcrichton requested elliottt for a review on PR #8806.

Wasmtime GitHub notifications bot (Jun 14 2024 at 17:53):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jun 14 2024 at 18:12):

alexcrichton updated PR #8806.

Wasmtime GitHub notifications bot (Jun 14 2024 at 18:12):

alexcrichton has enabled auto merge for PR #8806.

Wasmtime GitHub notifications bot (Jun 14 2024 at 18:35):

alexcrichton merged PR #8806.

Last updated: Dec 06 2025 at 06:05 UTC