alexcrichton opened PR #8794 from alexcrichton:disable-protection-key
to bytecodealliance:main
:
When the pooling allocator is itself disabled then there's no use for enabling MPK so this commit switches the implementation to all of the disabled versions of the primitives. This notably makes
ProtectionKey
an uninhabitedenum
meaning thatOption<ProtectionKey>
in theStore
is a zero-sized field and.is_none()
returns a constanttrue
. This is on the hot path of entering/exiting wasm so can help speed up things a bit there.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested pchickey for a review on PR #8794.
alexcrichton requested wasmtime-core-reviewers for a review on PR #8794.
fitzgen submitted PR review.
fitzgen merged PR #8794.
Last updated: Dec 23 2024 at 12:05 UTC