Wasmtime GitHub notifications bot (Jun 13 2024 at 00:44): Wasmtime GitHub notifications bot (Jun 13 2024 at 00:44):jameysharp requested wasmtime-core-reviewers for a review on PR #8791.
Wasmtime GitHub notifications bot (Jun 13 2024 at 00:44):jameysharp requested elliottt for a review on PR #8791.
Wasmtime GitHub notifications bot (Jun 13 2024 at 00:44):jameysharp opened PR #8791 from jameysharp:call-hook-context to bytecodealliance:main:
Rather than digging only the embedder's store-specific data out and passing that along, pass access to the entire Store. This is the same thing we do for epoch interruption hooks, including the annoyance of having to take the callback out of the store temporarily while calling it to avoid having multiple mutable borrows.
Wasmtime GitHub notifications bot (Jun 13 2024 at 01:03):jameysharp commented on PR #8791:
I think the only other example of this pattern in
StoreisStore::limiterand its async variant. I don't want to change that today but I think it's worth discussing whether we should do that eventually.
Wasmtime GitHub notifications bot (Jun 13 2024 at 14:55):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jun 13 2024 at 15:10):alexcrichton merged PR #8791.
Last updated: Dec 23 2024 at 13:07 UTC