Stream: git-wasmtime

Topic: wasmtime / PR #8790 wasi-nn: update openvino backend to v...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 29 2024 at 00:49):

abrown edited PR #8790.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 02 2024 at 22:11):

rahulchaphalkar updated PR #8790.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2024 at 17:12):

rahulchaphalkar updated PR #8790.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2024 at 17:37):

rahulchaphalkar commented on PR #8790:

@abrown I pushed some changes to fix failures due to some incompatibilities with Id enum. Tests are now passing, but vet step is failing, maybe due to one of my rebases. Can you vet the dependency? Thanks.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2024 at 23:15):

abrown commented on PR #8790:

I already did... where _did_ that commit go?

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2024 at 23:17):

abrown updated PR #8790.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2024 at 23:32):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2024 at 23:32):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2024 at 23:32):

abrown created PR review comment:

If possible, let's rewrite this as impl From<ExecutionTarget> for DeviceType<'static>. If not possible then at least change the function name and documentation.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2024 at 23:32):

abrown created PR review comment:

I think this could get cleaned up to something like: ElementType::Undefined | ElementType::Dynamic | ... => Err(BackendError::SomeNewVariant("{:?} is not yet supported in the openvino backend", element_type))

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2024 at 23:32):

abrown created PR review comment:

This can be a TryFrom since it is more useful to return an error to the user than crash Wasmtime with todo!.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2024 at 23:32):

abrown created PR review comment:

Similarly, this could be impl From<TensorType> for ElementType.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 09 2024 at 04:05):

lum1n0us submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 09 2024 at 04:05):

lum1n0us created PR review comment:

If no need to specify layout (of input tensor), and there is no PrePostProcessing in the whole file, Does it mean wasm code has to make sure the input tensor matches the requirement of model input? (I assume openvino models requires "NHWC" input)

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 22:04):

rahulchaphalkar updated PR #8790.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 22:08):

rahulchaphalkar submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 22:08):

rahulchaphalkar created PR review comment:

Hi Liang, yes this requires input tensor layout match the expected layout for model input.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2024 at 20:00):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2024 at 20:15):

abrown merged PR #8790.

Last updated: Dec 23 2024 at 12:05 UTC