Stream: git-wasmtime

Topic: wasmtime / PR #8778 Remove the `ModuleRuntimeInfo` trait

Wasmtime GitHub notifications bot (Jun 12 2024 at 03:53):

alexcrichton opened PR #8778 from alexcrichton:remove-unnecessary-trait to bytecodealliance:main:

Replace it with an enum of the two possibilities that it can be. This removes the need to have a trait dispatch indirection in the vm module. Previously this was required as wasmtime-runtime was a separate crate, but now it's no longer required.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 12 2024 at 03:53):

alexcrichton requested fitzgen for a review on PR #8778.

Wasmtime GitHub notifications bot (Jun 12 2024 at 03:53):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8778.

Wasmtime GitHub notifications bot (Jun 12 2024 at 17:49):

fitzgen submitted PR review:

Nice to start cleaning up these unnecessary trait objects now that wasmtime and wasmtime-runtime merged.

Wasmtime GitHub notifications bot (Jun 12 2024 at 18:10):

fitzgen merged PR #8778.

Last updated: Nov 22 2024 at 16:03 UTC