Stream: git-wasmtime

Topic: wasmtime / PR #8777 x64: Enable load sinking for small ty...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 11 2024 at 21:29):

afonso360 requested cfallin for a review on PR #8777.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 11 2024 at 21:29):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #8777.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 11 2024 at 21:29):

afonso360 opened PR #8777 from afonso360:x64-load-extends to bytecodealliance:main:

:wave: Hey,

This PR adds support for load sinking in extend instructions on the x64 backend. These were pretty much already supported, but by default the x64 backend doesn't load sink small types. (It'd be neat to fix that at some point)

The only change here is to allow it to do so for movzx and movsx. These instructions have the correct implementation for small types and shouldn't try to perform a load larger than the source type.

This should also be the last backend that needs this implementation, s390x already supports this, so the next PR in this series is removing the {u,s}loadNN instructions from cranelift.

CC: https://github.com/bytecodealliance/wasmtime/issues/6056

view this post on Zulip Wasmtime GitHub notifications bot (Jun 11 2024 at 21:52):

cfallin submitted PR review:

LGTM, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jun 11 2024 at 22:07):

cfallin merged PR #8777.

Last updated: Dec 23 2024 at 12:05 UTC