Stream: git-wasmtime

Topic: wasmtime / PR #8772 upgrade to wasm-tools 210

Wasmtime GitHub notifications bot (Jun 11 2024 at 02:48):

pchickey opened PR #8772 from bytecodealliance:pch/bump_wasm_tools_210 to bytecodealliance:main:

@alexcrichton I don't think that Resolve::select_world has an obvious way to work anymore - how do we select the default packageid when multiple packages can be defined? I used get(0) but this is an arbitrary choice. This comes up in the upgrade of wit-bindgen as well.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 11 2024 at 02:48):

pchickey requested elliottt for a review on PR #8772.

Wasmtime GitHub notifications bot (Jun 11 2024 at 02:48):

pchickey requested wasmtime-core-reviewers for a review on PR #8772.

Wasmtime GitHub notifications bot (Jun 11 2024 at 02:48):

pchickey requested wasmtime-default-reviewers for a review on PR #8772.

Wasmtime GitHub notifications bot (Jun 11 2024 at 15:14):

alexcrichton commented on PR #8772:

Ah this is something I should have dealt with before publishing. There's some follow-up work to https://github.com/bytecodealliance/wasm-tools/pull/1577 to improve world selection, so let me try to get that in today to update to that. Otherwise wit_component::resolve_world_from_name is the rough equivalent of what to do but I'd like to change that too.

Wasmtime GitHub notifications bot (Jun 11 2024 at 15:50):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 11 2024 at 15:50):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 11 2024 at 15:50):

alexcrichton created PR review comment:

With https://github.com/bytecodealliance/wasm-tools/pull/1611 this'll ferry along the pkgs argument to select_world which is what we want here.

Wasmtime GitHub notifications bot (Jun 11 2024 at 15:50):

alexcrichton created PR review comment:

This can be simplified a bit by using Resolve::append instead of iterating over the packages and calling push manually, although that does the same thing too.

Wasmtime GitHub notifications bot (Jun 11 2024 at 21:15):

pchickey commented on PR #8772:

Lets wait to upgrade until 211 is out.

Wasmtime GitHub notifications bot (Jun 11 2024 at 21:15):

pchickey closed without merge PR #8772.

Last updated: Dec 23 2024 at 12:05 UTC