Stream: git-wasmtime

Topic: wasmtime / PR #8770 Fix riscv64 for no-std


view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2024 at 23:25):

theoparis opened PR #8770 from theoparis:main to bytecodealliance:main:

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
See issue #8768

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2024 at 23:25):

theoparis requested alexcrichton for a review on PR #8770.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2024 at 23:25):

theoparis requested wasmtime-core-reviewers for a review on PR #8770.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2024 at 23:27):

alexcrichton submitted PR review:

Thanks for this!

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2024 at 23:27):

alexcrichton has enabled auto merge for PR #8770.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2024 at 23:48):

alexcrichton merged PR #8770.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 22 2024 at 09:31):

stlankes commented on PR #8770:

The latest release (22.0) is 2 days old and doesn't include this PR. Is this a correct behavior?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 22 2024 at 09:33):

stlankes edited a comment on PR #8770:

The latest release (22.0) is 2 days old and doesn't include this PR. Is this what is intended?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 22 2024 at 18:17):

cfallin commented on PR #8770:

Is this what is intended?

Yes! Our release process is to branch the release branch on the 5th of each month, and let things be tested and bugs be discovered on main for at least two weeks (backporting fixes as needed) then release from that branch on the 20th. This ensures that every change and new feature has between two and six weeks of testing and fuzzing.

We didn't always do things this way but the procedure is from hard-earned experience where changes slipped in just before release have almost no testing and can cause problems. This PR should be included in the next release (23.0) on July 20.

You can see a bit more about the rationale in #3955.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 23 2024 at 05:58):

stlankes commented on PR #8770:

Sounds like a reasonable strategy!


Last updated: Dec 23 2024 at 12:05 UTC