Stream: git-wasmtime

Topic: wasmtime / PR #8765 riscv64: Add support for `load+extend...

Wasmtime GitHub notifications bot (Jun 10 2024 at 21:08):

afonso360 opened PR #8765 from afonso360:riscv-load-sink to bytecodealliance:main:

:wave: Hey,

This PR adds support for merging {s,u}extend instructions into a preceding load.

RISC-V doesn't have sinkable loads per se, but the regular load instructions sign / zero extend the loaded values by default. So here we model that by pretending that that is a sinkable load on an extend instruction.

This PR is also a part of #6056. I'm working on that, the first step is to support generating the same code with load+extend on all backends as we currently do with the specialized {u,s}loadNN instructions.

Wasmtime GitHub notifications bot (Jun 10 2024 at 21:08):

afonso360 requested fitzgen for a review on PR #8765.

Wasmtime GitHub notifications bot (Jun 10 2024 at 21:08):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #8765.

Wasmtime GitHub notifications bot (Jun 10 2024 at 21:37):

fitzgen submitted PR review:

Very nice!

Wasmtime GitHub notifications bot (Jun 10 2024 at 21:37):

fitzgen submitted PR review:

Very nice!

Wasmtime GitHub notifications bot (Jun 10 2024 at 21:37):

fitzgen created PR review comment:

Maybe add a comment here about the extend(load()) use case and the asterisk around "sinkable" that you added in the PR description? That seems like good context to have when reading this code.

Wasmtime GitHub notifications bot (Jun 10 2024 at 23:44):

github-actions[bot] commented on PR #8765:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:riscv64", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 11 2024 at 09:06):

afonso360 updated PR #8765.

Wasmtime GitHub notifications bot (Jun 11 2024 at 09:06):

afonso360 has enabled auto merge for PR #8765.

Wasmtime GitHub notifications bot (Jun 11 2024 at 09:32):

afonso360 merged PR #8765.

Last updated: Oct 23 2024 at 20:03 UTC