Stream: git-wasmtime

Topic: wasmtime / PR #8750 Handle defined shared memories in dwa...

Wasmtime GitHub notifications bot (Jun 05 2024 at 22:16):

alexcrichton opened PR #8750 from alexcrichton:handle-defined-shared-memory to bytecodealliance:main:

This commit resolves an assert in the dwarf generating of core wasm modules when the module has a defined linear memory which is flagged shared. This is represented slightly differently in the VMContext than owned memories that aren't shared, and looks more like an imported memory. With support in #8740 it's now much easier to support this.

Closes #8652

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 05 2024 at 22:16):

alexcrichton requested fitzgen for a review on PR #8750.

Wasmtime GitHub notifications bot (Jun 05 2024 at 22:16):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8750.

Wasmtime GitHub notifications bot (Jun 06 2024 at 13:26):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 06 2024 at 13:41):

fitzgen merged PR #8750.

Last updated: Nov 22 2024 at 16:03 UTC