Wasmtime GitHub notifications bot (Jun 05 2024 at 21:56): Wasmtime GitHub notifications bot (Jun 05 2024 at 21:56):alexcrichton opened PR #8749 from alexcrichton:fix-adapter-shrinking-memory to bytecodealliance:main:
This commit is a fix to the WASIp1 adapter for components to better handle the case where the host does not use a utf-8 string encoding. This is never the case for
wasmtime-the-crate since it's a Rust-based host but this adapter is used outside of Wasmtime in jco, for example, where JS is not utf-8-based. When transcoding from utf-16 to utf-8 hosts may make an overlarge allocation and then shrink to a smaller allocation. This shrinking step has never been supported by the adapter and it's always aborted in this case.Aside: why is this only a problem now? This hasn't been an issue before now because jco bindings never actually shrank. In doing so however this violated the canonical ABI because allocations are guaranteed to be precisely sized. New debug assertions in newer versions of Rust caught this mistake. This means that when jco tried to add downsizing of the allocation it quickly hit this panic in the adapter.
The fix in this commit is to handle the specific case of shrinking memory. The specific fix is to simply ignore the shrinking of memory. This is pretty subtle though why it seems to work out well enough for now (and it's probably still buggy). For now though this is enough to get jco's test suite passing with a shrinking allocation.
Unfortunately I don't know of a way to test this in this repository. Wasmtime does not support multiple encodings of host strings, only guest strings. This means that there's no wasmtime-based way to pass a non-utf-8 string into a guest.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 05 2024 at 21:56):alexcrichton requested pchickey for a review on PR #8749.
Wasmtime GitHub notifications bot (Jun 05 2024 at 21:56):alexcrichton requested wasmtime-core-reviewers for a review on PR #8749.
Wasmtime GitHub notifications bot (Jun 05 2024 at 22:00):guybedford commented on PR #8749:
//cc @kateinoigakukun
Wasmtime GitHub notifications bot (Jun 05 2024 at 23:26):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Jun 05 2024 at 23:59):alexcrichton merged PR #8749.
Last updated: Nov 22 2024 at 16:03 UTC