Stream: git-wasmtime

Topic: wasmtime / PR #8739 Update `i64_from_iconst` to only matc...

Wasmtime GitHub notifications bot (Jun 03 2024 at 20:09):

alexcrichton opened PR #8739 from alexcrichton:iconst-only-match-iconst to bytecodealliance:main:

Previously this extractor would additionally match f32const and f64const which while theoretically not the end of the world can be confusing. Nowadays switch it to instead only matching the iconst instruction, as the name implies, and if necessary matching float constants is probably best done through separate ISLE lowering rules.

Closes #8723

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 03 2024 at 20:09):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #8739.

Wasmtime GitHub notifications bot (Jun 03 2024 at 20:09):

alexcrichton requested elliottt for a review on PR #8739.

Wasmtime GitHub notifications bot (Jun 04 2024 at 00:17):

elliottt submitted PR review:

Seems reasonable to me!

Wasmtime GitHub notifications bot (Jun 04 2024 at 02:44):

alexcrichton merged PR #8739.

Last updated: Dec 23 2024 at 12:05 UTC