Wasmtime GitHub notifications bot (May 31 2024 at 21:55): Wasmtime GitHub notifications bot (May 31 2024 at 21:55):alexcrichton opened PR #8726 from alexcrichton:make-test-more-robust to bytecodealliance:main:
This handles flakiness [seen online] and makes the test more robust. It was known that this test was not "fully robust" when added in #8671 and this is the "work over time" to handle failures we see in the wild.
[seen online]: https://github.com/bytecodealliance/wasmtime/actions/runs/9324271722/job/25669233977
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 31 2024 at 21:55):alexcrichton requested pchickey for a review on PR #8726.
Wasmtime GitHub notifications bot (May 31 2024 at 21:55):alexcrichton requested wasmtime-core-reviewers for a review on PR #8726.
Wasmtime GitHub notifications bot (Jun 05 2024 at 22:41):alexcrichton requested elliottt for a review on PR #8726.
Wasmtime GitHub notifications bot (Jun 05 2024 at 23:23):elliottt submitted PR review:
Thanks for the note in the test!
Wasmtime GitHub notifications bot (Jun 05 2024 at 23:59):alexcrichton merged PR #8726.
Last updated: Oct 23 2024 at 20:03 UTC