Stream: git-wasmtime

Topic: wasmtime / PR #8721 Always generate the same output struc...


view this post on Zulip Wasmtime GitHub notifications bot (May 31 2024 at 16:02):

alexcrichton opened PR #8721 from alexcrichton:full-bindings-generation-each-time to bytecodealliance:main:

Currently with the bindgen! macro when the with key is used then the generated bindings are different than if the with key was not used. Not only for replacement purposes but the generated bindings are missing two key pieces:

After this PR it means that each bindgen! macro should, in isolation, work for any other bindgen! macro invocation. It shouldn't be necessary to weave things together and remember how each macro was invoked along the way. This is primarily to unblock #8715 which is running into a case where tcp/udp are generated as sync but their dependency, wasi:sockets/network, is used from an upstream async version. The generated add_to_linker does not compile because tcp/udp depend on wasi:sockets/network isn't added to the linker. After fixing that it then required more modules to be generated, hence this PR.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2024 at 16:02):

alexcrichton requested pchickey for a review on PR #8721.

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2024 at 16:02):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8721.

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2024 at 16:03):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2024 at 16:03):

alexcrichton created PR review comment:

This was a bug from before this PR and probably shouldn't have ever worked...

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2024 at 16:34):

lann submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2024 at 17:23):

alexcrichton has enabled auto merge for PR #8721.

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2024 at 19:53):

pchickey submitted PR review:

cc @MendyBerger can you see if this improves any of the code we looked at together earlier this week?

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2024 at 20:07):

alexcrichton merged PR #8721.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2024 at 20:43):

MendyBerger commented on PR #8721:

@pchickey I'm unable to get the code to compile when I rebase on top of this git rev.
Let me know if it's important that I test it. If so, I'll spend some more time on this. It's probably something minor.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2024 at 20:43):

MendyBerger edited a comment on PR #8721:

@pchickey I'm unable to get the code to compile when I rebase on top of this git rev.
Let me know if it's important that I test it. If so, I'll spend some more time on this.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2024 at 20:44):

MendyBerger edited a comment on PR #8721:

@pchickey I'm unable to get the code to compile when I rebase on top of this git rev.
Let me know if it's important that I test it. If so, I'll spend some more time on it.


Last updated: Dec 23 2024 at 13:07 UTC