Wasmtime GitHub notifications bot (May 30 2024 at 23:00): Wasmtime GitHub notifications bot (May 30 2024 at 23:00):lpereira edited PR #8716.
Wasmtime GitHub notifications bot (May 30 2024 at 23:01):lpereira edited PR #8716:
The original idea of the filtering here was to avoid passing characters such as the NUL byte, whitespaces, or other things that could cause issues to tools that will consume this data. Since it's impractical to update the list of allowed characters every time a language that
compiles to Wasm generates symbols slightly differently, allow all graphic ASCII characters instead.(Tests don't need updating.)
Wasmtime GitHub notifications bot (May 30 2024 at 23:01):lpereira commented on PR #8716:
Alright, pushed a new version that only tests for a bad character if it's not a graphic ASCII character.
Wasmtime GitHub notifications bot (May 31 2024 at 14:51):alexcrichton submitted PR review:
Sorry yeah I don't want to cause too much trouble/headache with this. My gut is that something will go wrong if random emoji is fed to
objdumpand/or mixing in things like right-to-left and left-to-right characters and things like that, but I've got no concrete evidence and everything might handle it all just fine.In any case I think adjustments along the lines of this definitely make sense and are fine to land without trying to investigate deeply how tooling reacts to these symbols (since it's probably all fine anyway)
Wasmtime GitHub notifications bot (May 31 2024 at 15:05):alexcrichton merged PR #8716.
Last updated: Nov 22 2024 at 16:03 UTC