lann opened PR #8715 from lann:async-socket-addr-check
to bytecodealliance:main
:
Fixes #8714
lann requested wasmtime-core-reviewers for a review on PR #8715.
lann requested elliottt for a review on PR #8715.
pchickey submitted PR review.
This still needs the sync impls, which I did not understand before but now do (hopefully).
lann updated PR #8715.
This seems code-complete, but I'm getting bindgen errors that I'm not quite understanding:
error[E0277]: the trait bound `U: async_io::wasi::sockets::network::Host` is not satisfied --> crates/wasi/src/bindings.rs:9:9 | 9 | / wasmtime::component::bindgen!({ 10 | | path: "wit", 11 | | world: "wasi:cli/command", 12 | | tracing: true, ... | 41 | | }, 42 | | }); | |__________^ the trait `async_io::wasi::sockets::network::Host` is not implemented for `U`
lann submitted PR review.
lann created PR review comment:
Since we're breaking this signature anyway, I also
&SocketAddr
->SocketAddr
(which isCopy
).
@alexcrichton is working on bindgen improvements that ought to fix this.
alexcrichton commented on PR #8715:
With https://github.com/bytecodealliance/wasmtime/pull/8721 I think this PR should be good to go
lann updated PR #8715.
Looks like this is ready to go now
alexcrichton merged PR #8715.
@alexcrichton OK to backport this to 22?
lann edited a comment on PR #8715:
@alexcrichton OK to backport this to 22?
_Edit: never mind, not sure what I'm seeing..._
Last updated: Nov 22 2024 at 17:03 UTC