Stream: git-wasmtime

Topic: wasmtime / PR #8715 wasi: Make WasiCtxBuilder::socket_add...

Wasmtime GitHub notifications bot (May 30 2024 at 21:35):

lann opened PR #8715 from lann:async-socket-addr-check to bytecodealliance:main:

Fixes #8714

Wasmtime GitHub notifications bot (May 30 2024 at 21:35):

lann requested wasmtime-core-reviewers for a review on PR #8715.

Wasmtime GitHub notifications bot (May 30 2024 at 21:35):

lann requested elliottt for a review on PR #8715.

Wasmtime GitHub notifications bot (May 30 2024 at 22:42):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (May 31 2024 at 13:00):

lann commented on PR #8715:

This still needs the sync impls, which I did not understand before but now do (hopefully).

Wasmtime GitHub notifications bot (May 31 2024 at 14:19):

lann updated PR #8715.

Wasmtime GitHub notifications bot (May 31 2024 at 14:20):

lann commented on PR #8715:

This seems code-complete, but I'm getting bindgen errors that I'm not quite understanding:

error[E0277]: the trait bound `U: async_io::wasi::sockets::network::Host` is not satisfied
  --> crates/wasi/src/bindings.rs:9:9
   |
9  | /         wasmtime::component::bindgen!({
10 | |             path: "wit",
11 | |             world: "wasi:cli/command",
12 | |             tracing: true,
...  |
41 | |             },
42 | |         });
   | |__________^ the trait `async_io::wasi::sockets::network::Host` is not implemented for `U`

Wasmtime GitHub notifications bot (May 31 2024 at 14:22):

lann submitted PR review.

Wasmtime GitHub notifications bot (May 31 2024 at 14:22):

lann created PR review comment:

Since we're breaking this signature anyway, I also &SocketAddr -> SocketAddr (which is Copy).

Wasmtime GitHub notifications bot (May 31 2024 at 15:14):

lann commented on PR #8715:

@alexcrichton is working on bindgen improvements that ought to fix this.

Wasmtime GitHub notifications bot (May 31 2024 at 16:03):

alexcrichton commented on PR #8715:

With https://github.com/bytecodealliance/wasmtime/pull/8721 I think this PR should be good to go

Wasmtime GitHub notifications bot (May 31 2024 at 20:54):

lann updated PR #8715.

Wasmtime GitHub notifications bot (May 31 2024 at 21:05):

lann commented on PR #8715:

Looks like this is ready to go now

Wasmtime GitHub notifications bot (May 31 2024 at 21:29):

alexcrichton merged PR #8715.

Wasmtime GitHub notifications bot (Jun 11 2024 at 13:33):

lann commented on PR #8715:

@alexcrichton OK to backport this to 22?

Wasmtime GitHub notifications bot (Jun 11 2024 at 13:33):

lann edited a comment on PR #8715:

@alexcrichton OK to backport this to 22?

_Edit: never mind, not sure what I'm seeing..._

Last updated: Oct 23 2024 at 20:03 UTC