Wasmtime GitHub notifications bot (May 28 2024 at 19:56): Wasmtime GitHub notifications bot (May 28 2024 at 19:56):alexcrichton opened PR #8701 from alexcrichton:riscv-special-case-zero-for-fconst-zero to bytecodealliance:main:
This commit is inspired by discussion on #8695 which made me remember the discussion around #7162 historically. In lieu of a deeper fix for the issue of "why can't
iconst 0use(zero_reg)" it's still possible to add special-cases to rules throughout the backend so this commit does that for generating zero-value floats.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 28 2024 at 19:56):alexcrichton requested elliottt for a review on PR #8701.
Wasmtime GitHub notifications bot (May 28 2024 at 19:56):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #8701.
Wasmtime GitHub notifications bot (May 28 2024 at 21:07):alexcrichton updated PR #8701.
Wasmtime GitHub notifications bot (May 28 2024 at 21:33):afonso360 submitted PR review:
Nice! Thanks!
Wasmtime GitHub notifications bot (May 29 2024 at 02:01):alexcrichton commented on PR #8701:
Received request to deprovision: The request was cancelled by the remote provider.
After 4 times in a row I'm going to deprovision myself for tonight.
Wasmtime GitHub notifications bot (May 29 2024 at 16:01):alexcrichton updated PR #8701.
Wasmtime GitHub notifications bot (May 30 2024 at 20:06):alexcrichton merged PR #8701.
Last updated: Dec 23 2024 at 12:05 UTC