Stream: git-wasmtime

Topic: wasmtime / PR #8700 Remove ArgumentPurpose::StackLimit

Wasmtime GitHub notifications bot (May 28 2024 at 17:51):

elliottt opened PR #8700 from elliottt:trevor/remove-stacklimit-arg to bytecodealliance:main:

The special stack_limit argument annotation is currently unused, so let's remove it. I have grepped through the cg clif source and didn't find anything that obviously relied on this annotation.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 28 2024 at 17:53):

elliottt updated PR #8700.

Wasmtime GitHub notifications bot (May 28 2024 at 18:01):

alexcrichton commented on PR #8700:

This was originally added for Wasmtime but since then Wasmtime has moved on, so sounds reasonable to me to remove :+1:

Wasmtime GitHub notifications bot (May 28 2024 at 18:03):

elliottt has marked PR #8700 as ready for review.

Wasmtime GitHub notifications bot (May 28 2024 at 18:03):

elliottt requested fitzgen for a review on PR #8700.

Wasmtime GitHub notifications bot (May 28 2024 at 18:03):

elliottt requested wasmtime-compiler-reviewers for a review on PR #8700.

Wasmtime GitHub notifications bot (May 28 2024 at 18:07):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (May 28 2024 at 18:46):

elliottt merged PR #8700.

Last updated: Nov 22 2024 at 16:03 UTC