Stream: git-wasmtime

Topic: wasmtime / PR #8698 Allow empty block param lists in clif...

Wasmtime GitHub notifications bot (May 28 2024 at 16:39):

elliottt opened PR #8698 from elliottt:trevor/allow-empty-parens to bytecodealliance:main:

Allow block definitions to be parsed with empty parens, rather than requiring that there be a non-empty list of arguments if they're present.

function %f() {
block0():
    trap ud0
}

This is a pretty superficial change, but when iterating on clif files, it is nice to have to make fewer changes to get to a file that can make it through the pipeline.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 28 2024 at 16:39):

elliottt requested abrown for a review on PR #8698.

Wasmtime GitHub notifications bot (May 28 2024 at 16:39):

elliottt requested wasmtime-compiler-reviewers for a review on PR #8698.

Wasmtime GitHub notifications bot (May 28 2024 at 16:42):

cfallin submitted PR review:

Very reasonable ergonomics tweak, thanks!

Wasmtime GitHub notifications bot (May 28 2024 at 16:42):

cfallin has enabled auto merge for PR #8698.

Wasmtime GitHub notifications bot (May 28 2024 at 17:02):

cfallin merged PR #8698.

Last updated: Dec 23 2024 at 12:05 UTC