Wasmtime GitHub notifications bot (May 25 2024 at 19:55): Wasmtime GitHub notifications bot (May 25 2024 at 19:55):alexcrichton opened PR #8693 from alexcrichton:component-dwarf to bytecodealliance:main:
This commit updates the native-DWARF processing (the
-D debug-infoCLI flag) to support components. Previously component support was not implemented and if there was more than one core wasm module within a component then dwarf would be ignored entirely.This commit contains a number of refactorings to plumb a more full compilation context throughout the dwarf processing pipeline. Previously the data structures used only were able to support a single module. A new
Compilationstructure is used to represent the results of an entire compilation and is plumbed through the various locations. Most of the refactorings in this commit were then to extend loops to loop over more things and handle the case where there is more than one core wasm module.I'll admit I'm not expert on DWARF but basic examples appear to work locally and most of the additions here seemed relatively straightforward in terms of "add another loop to iterate over more things" but I'm not 100% sure how well this will work. In theory this now supports concatenating DWARF sections across multiple core wasm modules, but that's not super well tested.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 25 2024 at 19:55):alexcrichton requested elliottt for a review on PR #8693.
Wasmtime GitHub notifications bot (May 25 2024 at 19:55):alexcrichton requested wasmtime-core-reviewers for a review on PR #8693.
Wasmtime GitHub notifications bot (May 25 2024 at 20:45):alexcrichton updated PR #8693.
Wasmtime GitHub notifications bot (May 25 2024 at 23:44):github-actions[bot] commented on PR #8693:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "wasmtime:api", "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jun 03 2024 at 16:10):alexcrichton updated PR #8693.
Wasmtime GitHub notifications bot (Jun 03 2024 at 16:20):alexcrichton updated PR #8693.
Wasmtime GitHub notifications bot (Jun 05 2024 at 06:40):elliottt submitted PR review:
Awesome!
Wasmtime GitHub notifications bot (Jun 05 2024 at 06:40):elliottt submitted PR review:
Awesome!
Wasmtime GitHub notifications bot (Jun 05 2024 at 06:40):elliottt created PR review comment:
Nice!
Wasmtime GitHub notifications bot (Jun 05 2024 at 17:06):alexcrichton updated PR #8693.
Wasmtime GitHub notifications bot (Jun 05 2024 at 17:06):alexcrichton has enabled auto merge for PR #8693.
Wasmtime GitHub notifications bot (Jun 05 2024 at 21:16):alexcrichton updated PR #8693.
Wasmtime GitHub notifications bot (Jun 05 2024 at 21:16):alexcrichton has enabled auto merge for PR #8693.
Wasmtime GitHub notifications bot (Jun 05 2024 at 21:39):alexcrichton merged PR #8693.
Last updated: Dec 23 2024 at 12:05 UTC