Stream: git-wasmtime

Topic: wasmtime / PR #8691 Fix runtime::vm::cow tests on hosts w...


view this post on Zulip Wasmtime GitHub notifications bot (May 25 2024 at 00:58):

refi64 requested alexcrichton for a review on PR #8691.

view this post on Zulip Wasmtime GitHub notifications bot (May 25 2024 at 00:58):

refi64 requested wasmtime-core-reviewers for a review on PR #8691.

view this post on Zulip Wasmtime GitHub notifications bot (May 25 2024 at 00:58):

refi64 opened PR #8691 from refi64:16k-pages to bytecodealliance:main:

A bunch of the hardcoded sizes were only multiples of 4k, so they'd crash on hosts with a different page size. Fix this by making them all based on the runtime page size instead.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (May 25 2024 at 22:56):

alexcrichton submitted PR review:

Thanks for this!

view this post on Zulip Wasmtime GitHub notifications bot (May 25 2024 at 23:11):

alexcrichton merged PR #8691.


Last updated: Dec 23 2024 at 12:05 UTC