Wasmtime GitHub notifications bot (May 25 2024 at 00:58): Wasmtime GitHub notifications bot (May 25 2024 at 00:58):refi64 requested alexcrichton for a review on PR #8691.
Wasmtime GitHub notifications bot (May 25 2024 at 00:58):refi64 requested wasmtime-core-reviewers for a review on PR #8691.
Wasmtime GitHub notifications bot (May 25 2024 at 00:58):refi64 opened PR #8691 from refi64:16k-pages to bytecodealliance:main:
A bunch of the hardcoded sizes were only multiples of 4k, so they'd crash on hosts with a different page size. Fix this by making them all based on the runtime page size instead.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 25 2024 at 22:56):alexcrichton submitted PR review:
Thanks for this!
Wasmtime GitHub notifications bot (May 25 2024 at 23:11):alexcrichton merged PR #8691.
Last updated: Nov 22 2024 at 17:03 UTC