Stream: git-wasmtime

Topic: wasmtime / PR #8689 wasmtime: `VMRuntimeLimits` pointer i...

Wasmtime GitHub notifications bot (May 24 2024 at 08:10):

jameysharp opened PR #8689 from jameysharp:limits-ptr-is-ssa to bytecodealliance:main:

We don't need to use cranelift-frontend to keep track of the location of the VMRuntimeLimits pointer, because it is loaded once on entry to the function and never changed afterward.

Instead, just track the correct SSA Value.

Wasmtime GitHub notifications bot (May 24 2024 at 08:10):

jameysharp requested fitzgen for a review on PR #8689.

Wasmtime GitHub notifications bot (May 24 2024 at 08:10):

jameysharp requested wasmtime-core-reviewers for a review on PR #8689.

Wasmtime GitHub notifications bot (May 24 2024 at 15:46):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (May 24 2024 at 15:46):

fitzgen created PR review comment:

Can we debug assert that self.vmruntime_limits_ptr is the reserved value before we initialize it, to make sure that we aren't defining it multiple times? And/or use an Option or PackedOption for the field?

Wasmtime GitHub notifications bot (May 24 2024 at 15:46):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (May 24 2024 at 15:46):

fitzgen created PR review comment:

Similarly, can we debug assert that it has been initialized here?

Wasmtime GitHub notifications bot (May 24 2024 at 17:59):

jameysharp updated PR #8689.

Wasmtime GitHub notifications bot (May 24 2024 at 19:01):

jameysharp merged PR #8689.

Last updated: Dec 23 2024 at 12:05 UTC