Stream: git-wasmtime

Topic: wasmtime / PR #8686 Use `[su]extend_maybe` in the `iconst...

view this post on Zulip Wasmtime GitHub notifications bot (May 23 2024 at 07:08):

scottmcm requested wasmtime-compiler-reviewers for a review on PR #8686.

view this post on Zulip Wasmtime GitHub notifications bot (May 23 2024 at 07:08):

scottmcm opened PR #8686 from scottmcm:extended-iconst to bytecodealliance:main:

This enables various things -- like x * 2 → x + x and x * -1 → -x -- for 128-bit numbers as well.

Thanks to @jameysharp over in https://github.com/bytecodealliance/wasmtime/pull/8653#issuecomment-2125435660 for noticing that these extractors weren't ever going to match 128-bit numbers as-written, even though the rules could produce 128-bit values.

view this post on Zulip Wasmtime GitHub notifications bot (May 23 2024 at 07:08):

scottmcm requested elliottt for a review on PR #8686.

view this post on Zulip Wasmtime GitHub notifications bot (May 23 2024 at 07:19):

jameysharp submitted PR review:

Very nice, thank you!

view this post on Zulip Wasmtime GitHub notifications bot (May 23 2024 at 07:33):

jameysharp merged PR #8686.

Last updated: Nov 22 2024 at 16:03 UTC