Stream: git-wasmtime

Topic: wasmtime / PR #8682 Fix tail calls being turned on by def...

Wasmtime GitHub notifications bot (May 22 2024 at 20:56):

alexcrichton requested pchickey for a review on PR #8682.

Wasmtime GitHub notifications bot (May 22 2024 at 20:56):

alexcrichton opened PR #8682 from alexcrichton:enable-tail-calls to bytecodealliance:main:

Logic in Config to conditionally enable tail calls wasn't handling the case where the configured compiler strategy was Strategy::Auto meaning that by default tail calls weren't actually enabled. This commit refactors handling of Strategy to avoid storing Strategy::Auto in CompilerConfig so tests against it can use either cranelift or winch.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 22 2024 at 20:56):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8682.

Wasmtime GitHub notifications bot (May 22 2024 at 21:10):

alexcrichton updated PR #8682.

Wasmtime GitHub notifications bot (May 22 2024 at 21:14):

alexcrichton updated PR #8682.

Wasmtime GitHub notifications bot (May 22 2024 at 21:22):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (May 22 2024 at 21:37):

alexcrichton merged PR #8682.

Last updated: Dec 23 2024 at 13:07 UTC