Wasmtime GitHub notifications bot (May 21 2024 at 14:10): Wasmtime GitHub notifications bot (May 21 2024 at 14:10):rylev opened PR #8672 from rylev:defined-unknonw to bytecodealliance:main:
Fixes #8645
Wasmtime GitHub notifications bot (May 21 2024 at 14:10):rylev requested wasmtime-core-reviewers for a review on PR #8672.
Wasmtime GitHub notifications bot (May 21 2024 at 14:10):rylev requested fitzgen for a review on PR #8672.
Wasmtime GitHub notifications bot (May 21 2024 at 14:47):alexcrichton submitted PR review:
Thanks! Could this be written with a recursive helper that operates on a
&ComponentType(or similar) and aLinkerInstance? That'll help remove some minor duplication here and additionally handle the fully general case of all component imports.Additionally could this return an error for unsupported imports? For example this can't fill in the import of a component or import of a module at this time so I think those should return an error rather than being silently ignored.
And finally, mind adding a test or two for this?
Wasmtime GitHub notifications bot (May 21 2024 at 18:47):rylev updated PR #8672.
Wasmtime GitHub notifications bot (May 21 2024 at 18:50):rylev updated PR #8672.
Wasmtime GitHub notifications bot (May 21 2024 at 18:50):rylev requested alexcrichton for a review on PR #8672.
Wasmtime GitHub notifications bot (May 21 2024 at 18:57):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 21 2024 at 18:57):alexcrichton has enabled auto merge for PR #8672.
Wasmtime GitHub notifications bot (May 21 2024 at 19:12):alexcrichton merged PR #8672.
Last updated: Oct 23 2024 at 20:03 UTC