Wasmtime GitHub notifications bot (May 17 2024 at 00:42): Wasmtime GitHub notifications bot (May 17 2024 at 00:42):elliottt opened PR #8643 from elliottt:trevor/remove-nominal-sp to bytecodealliance:main:
As we now keep SP at the same place throughout the function body, or only modify
it within the emission for individual pseudo-ops like call, we no longer need
the notion of the nominal-SP. This PR removes all mentions of the nominal SP,
and reworks the docs to more accurately describe the frame layout the backends
currently assume.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 17 2024 at 00:43):elliottt edited PR #8643:
As we now keep SP at the same place throughout the function body, or only modify it within the emission for individual pseudo-ops like call, we no longer need the notion of the nominal-SP. This PR removes all mentions of the nominal SP, and reworks the docs to more accurately describe the frame layout the backends currently assume.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 17 2024 at 00:43):elliottt edited PR #8643:
As we now keep SP at the same place throughout the function body, or only modify it within the emission for individual pseudo-ops like call, we no longer need the notion of the nominal-SP. This PR removes all mentions of the nominal SP, and reworks the docs to more accurately describe the frame layout the backends currently assume.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 17 2024 at 00:47):elliottt edited PR #8643:
As we now keep SP at the same place throughout the function body, or only modify it within the emission for individual pseudo-ops like call, we no longer need the notion of the nominal-SP. This PR removes all mentions of the nominal SP, and reworks the docs to more accurately describe the frame layout the backends currently assume.
I'm not 100% sold on the change of representation for slot offsets in the riscv64 backend, and am happy to take suggestions for a better representation than
(slot).<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 17 2024 at 00:48):elliottt has marked PR #8643 as ready for review.
Wasmtime GitHub notifications bot (May 17 2024 at 00:48):elliottt requested abrown for a review on PR #8643.
Wasmtime GitHub notifications bot (May 17 2024 at 00:48):elliottt requested wasmtime-compiler-reviewers for a review on PR #8643.
Wasmtime GitHub notifications bot (May 17 2024 at 00:48):elliottt requested jameysharp for a review on PR #8643.
Wasmtime GitHub notifications bot (May 17 2024 at 02:44):github-actions[bot] commented on PR #8643:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (May 17 2024 at 13:37):abrown submitted PR review:
Looks good to me. I didn't page in all the context try to completely grok the doc changes for correctness but they seemed reasonable otherwise.
Wasmtime GitHub notifications bot (May 17 2024 at 13:51):abrown merged PR #8643.
Last updated: Oct 23 2024 at 20:03 UTC