Stream: git-wasmtime

Topic: wasmtime / PR #8641 Fix some typos

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 22:45):

FrankReh opened PR #8641 from FrankReh:just-a-few-typos to bytecodealliance:main:

Corrected typos from various parts of the crate.

The commits are broken down into different parts in case there are different owners who would take on reviewing.

Most are in comments. A few are in asserts and error messages.

Before anyone gets too annoyed with me, consider the time saved for all who will be reading this code in the years to come. :pray:

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 22:45):

FrankReh requested alexcrichton for a review on PR #8641.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 22:45):

FrankReh requested wasmtime-fuzz-reviewers for a review on PR #8641.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 22:45):

FrankReh requested wasmtime-core-reviewers for a review on PR #8641.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 22:45):

FrankReh requested wasmtime-compiler-reviewers for a review on PR #8641.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 22:45):

FrankReh requested fitzgen for a review on PR #8641.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 22:45):

FrankReh requested wasmtime-default-reviewers for a review on PR #8641.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 22:53):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 22:54):

abrown commented on PR #8641:

Might need to run clang-format on one of those header files...

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 22:57):

FrankReh commented on PR #8641:

Might need to run clang-format on one of those header files...

I'm very much over my head using the c headers. It's been a minute since I was compiling c. I'm happy to take help in understanding what I should do get the changes to the headers accepted by ci, but I can also revert them if the changes are making things too complicated.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 23:07):

abrown created PR review comment:

I think it boils down to this:

 * This context pointer is used pervasively throughout Wasmtime's API. This can
 * be acquired from #wasmtime_store_context or #wasmtime_caller_context. The

clang-format wants the comments to all be a certain length.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 23:07):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 23:08):

abrown updated PR #8641.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 23:09):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 23:09):

abrown created PR review comment:

I went ahead and merged this suggestion to see if there are any other problems.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 23:09):

abrown has enabled auto merge for PR #8641.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2024 at 23:35):

abrown merged PR #8641.

Last updated: Dec 23 2024 at 12:05 UTC