Stream: git-wasmtime

Topic: wasmtime / PR #8638 Fix the change introduced in #8636, a...

Wasmtime GitHub notifications bot (May 16 2024 at 18:07):

elliottt requested abrown for a review on PR #8638.

Wasmtime GitHub notifications bot (May 16 2024 at 18:07):

elliottt requested wasmtime-compiler-reviewers for a review on PR #8638.

Wasmtime GitHub notifications bot (May 16 2024 at 18:07):

elliottt opened PR #8638 from elliottt:trevor/fix-vcode-cfaoffset to bytecodealliance:main:

The offset computed in compute_value_labels_ranges is relative to the CFA, not the current value of SP, which means that the change introduced in #8636 is incorrect. This PR fixes that misunderstanding, and renames the sp_to_caller_sp_offset function to slot_base_to_caller_sp_offset to make it really clear what the value being computed is used for.

cc @jameysharp
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 16 2024 at 18:08):

elliottt requested jameysharp for a review on PR #8638.

Wasmtime GitHub notifications bot (May 16 2024 at 18:19):

jameysharp submitted PR review:

I believe this is correct, thank you! It's very confusing to reason about.

Wasmtime GitHub notifications bot (May 16 2024 at 18:36):

elliottt merged PR #8638.

Last updated: Dec 23 2024 at 12:05 UTC