Stream: git-wasmtime

Topic: wasmtime / PR #8636 Including the outgoing arguments area...

Wasmtime GitHub notifications bot (May 16 2024 at 16:28):

elliottt opened PR #8636 from elliottt:trevor/include-outgoing-args-sp-to-caller-sp to bytecodealliance:main:

After the recent changes to eagerly allocate space for outgoing arguments in the
stack frame, the definition of the nominal_sp_to_caller_sp_offset function no
longer seems correct: it assumes the old behavior where SP was always at the end
of the fixed allocation area, and not at the end of the outoging args.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 16 2024 at 16:29):

elliottt edited PR #8636:

After the recent changes to eagerly allocate space for outgoing arguments in the stack frame, the definition of the nominal_sp_to_caller_sp_offset function no longer seems correct: it assumes the old behavior where SP was always at the end of the fixed allocation area, and not at the end of the outoging args.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 16 2024 at 16:36):

elliottt has marked PR #8636 as ready for review.

Wasmtime GitHub notifications bot (May 16 2024 at 16:36):

elliottt requested cfallin for a review on PR #8636.

Wasmtime GitHub notifications bot (May 16 2024 at 16:36):

elliottt requested wasmtime-compiler-reviewers for a review on PR #8636.

Wasmtime GitHub notifications bot (May 16 2024 at 16:46):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (May 16 2024 at 17:31):

elliottt merged PR #8636.

Last updated: Dec 23 2024 at 12:05 UTC