Wasmtime GitHub notifications bot (May 15 2024 at 14:29): Wasmtime GitHub notifications bot (May 15 2024 at 14:29):afonso360 opened PR #8625 from afonso360:cprop-float to bytecodealliance:main:
:wave: Hey,
This PR adds constant propagation for the few bitwise floating point operations that we have (
fneg/fabs/fcopysign). Since these operations are guaranteed to be done in a bitwise manner it should be safe to constant propagate them.
Wasmtime GitHub notifications bot (May 15 2024 at 14:29):afonso360 requested fitzgen for a review on PR #8625.
Wasmtime GitHub notifications bot (May 15 2024 at 14:29):afonso360 requested wasmtime-compiler-reviewers for a review on PR #8625.
Wasmtime GitHub notifications bot (May 15 2024 at 15:09):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 15 2024 at 15:25):fitzgen submitted PR review:
Thanks! One nitpick below :)
Wasmtime GitHub notifications bot (May 15 2024 at 15:25):fitzgen submitted PR review:
Thanks! One nitpick below :)
Wasmtime GitHub notifications bot (May 15 2024 at 15:25):fitzgen created PR review comment:
Can we move these to
prelude.isle?
Wasmtime GitHub notifications bot (May 15 2024 at 15:44):github-actions[bot] commented on PR #8625:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (May 15 2024 at 21:26):afonso360 updated PR #8625.
Wasmtime GitHub notifications bot (May 15 2024 at 22:10):afonso360 merged PR #8625.
Last updated: Nov 22 2024 at 16:03 UTC