Stream: git-wasmtime

Topic: wasmtime / PR #8615 Fix the version of mach2 in Cargo.toml

Wasmtime GitHub notifications bot (May 14 2024 at 14:58):

ulan requested abrown for a review on PR #8615.

Wasmtime GitHub notifications bot (May 14 2024 at 14:58):

ulan opened PR #8615 from ulan:release-21.0.0 to bytecodealliance:release-21.0.0:

The toml file specifies version 0.4.1 instead of 0.4.2.

Using version 0.4.1 produces a compile error:

error[E0432]: unresolved import `mach2::ndr`
  --> external/crate_index__wasmtime-runtime-20.0.2/src/sys/unix/machports.rs:44:12
   |
44 | use mach2::ndr::*;
   |            ^^^ could not find `ndr` in `mach2`

That's because ndr was added in version 0.4.2.

Note that the lock file specifies version 0.4.2 which explains why this error doesn't happen normally.

Wasmtime GitHub notifications bot (May 14 2024 at 14:58):

ulan requested wasmtime-default-reviewers for a review on PR #8615.

Wasmtime GitHub notifications bot (May 14 2024 at 15:00):

ulan commented on PR #8615:

@cfallin: here is the cherrypick onto 21 ^ (I cannot edit the reviewer and the system autoassigned @abrown).

Wasmtime GitHub notifications bot (May 14 2024 at 15:04):

cfallin submitted PR review:

Thanks very much!

Wasmtime GitHub notifications bot (May 14 2024 at 15:04):

cfallin has enabled auto merge for PR #8615.

Wasmtime GitHub notifications bot (May 14 2024 at 15:20):

cfallin merged PR #8615.

Last updated: Nov 22 2024 at 17:03 UTC