Stream: git-wasmtime

Topic: wasmtime / PR #8614 Fix the version of mach2 in Cargo.toml

Wasmtime GitHub notifications bot (May 14 2024 at 08:44):

ulan opened PR #8614 from ulan:fix-mach2-dep to bytecodealliance:main:

The toml file specifies version 0.4.1 instead of 0.4.2.

Using version 0.4.1 produces a compile error:

error[E0432]: unresolved import `mach2::ndr`
  --> external/crate_index__wasmtime-runtime-20.0.2/src/sys/unix/machports.rs:44:12
   |
44 | use mach2::ndr::*;
   |            ^^^ could not find `ndr` in `mach2`

That's because ndr was added in version 0.4.2.

Note that the lock file specifies version 0.4.2 which explains why this error doesn't happen normally.

Wasmtime GitHub notifications bot (May 14 2024 at 08:44):

ulan requested wasmtime-default-reviewers for a review on PR #8614.

Wasmtime GitHub notifications bot (May 14 2024 at 08:44):

ulan requested cfallin for a review on PR #8614.

Wasmtime GitHub notifications bot (May 14 2024 at 14:22):

cfallin submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (May 14 2024 at 14:24):

cfallin commented on PR #8614:

@ulan if you want to cherrypick this onto release-21.0.0 in a separate PR too, I'm happy to approve that as well. The release branched last week and is going out next week so we'll want this fix there too, probably.

Wasmtime GitHub notifications bot (May 14 2024 at 14:29):

ulan commented on PR #8614:

@ulan if you want to cherrypick this onto release-21.0.0 in a separate PR too, I'm happy to approve that as well. The release branched last week and is going out next week so we'll want this fix there too, probably.

Thanks for the offer! We solved this on our end, so we don't need the cherrypick. I am happy to prepare the cherrypick PRs if you think it would be worthwhile for other users (which seems unlikely considering that no one reported the issue).

Wasmtime GitHub notifications bot (May 14 2024 at 14:33):

cfallin commented on PR #8614:

For completeness we should probably do so; I'm happy to do it quickly otherwise.

Wasmtime GitHub notifications bot (May 14 2024 at 14:39):

ulan commented on PR #8614:

For completeness we should probably do so; I'm happy to do it quickly otherwise.

Sounds good! I'll cherry pick to 21.

The release branched last week and is going out next week so we'll want this fix there too, probably.

Do you mean that would be release-22.0.0 that would also need this fix?

Wasmtime GitHub notifications bot (May 14 2024 at 14:47):

cfallin merged PR #8614.

Wasmtime GitHub notifications bot (May 14 2024 at 14:56):

cfallin commented on PR #8614:

Oh, no, I meant that release-21.0.0 branched last week, then waits for two weeks (to give time to find and cherrypick issues just like this :-) ) and releases next week. Thanks!

Wasmtime GitHub notifications bot (May 14 2024 at 15:01):

ulan commented on PR #8614:

The cherrypick: https://github.com/bytecodealliance/wasmtime/pull/8615

Last updated: Nov 22 2024 at 16:03 UTC