Stream: git-wasmtime

Topic: wasmtime / PR #8610 Dynamically determine whether to pool...

Wasmtime GitHub notifications bot (May 13 2024 at 20:33):

alexcrichton opened PR #8610 from alexcrichton:conditionally-pool-on-serve to bytecodealliance:main:

This commit aims to address #8607 by dynamically determining whether the pooling allocator should be used rather than unconditionally using it. It looks like some systems don't have enough virtual memory to support the default configuration settings so this should help wasmtime serve work on those systems.

Closes #8607

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 13 2024 at 20:33):

alexcrichton requested fitzgen for a review on PR #8610.

Wasmtime GitHub notifications bot (May 13 2024 at 20:33):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8610.

Wasmtime GitHub notifications bot (May 13 2024 at 20:42):

abrown submitted PR review.

Wasmtime GitHub notifications bot (May 13 2024 at 20:57):

alexcrichton commented on PR #8610:

I'm going to seek confirmation this fixes the issue before merging since I don't have a system to test on myself.

Wasmtime GitHub notifications bot (May 14 2024 at 13:20):

matsbror commented on PR #8610:

I can confirm that it works on the VisionFive 2 board (RISCV64) and the Nvidia Jetson Nano board.

Wasmtime GitHub notifications bot (May 14 2024 at 14:48):

alexcrichton commented on PR #8610:

Thanks for the confirmation!

Wasmtime GitHub notifications bot (May 14 2024 at 15:27):

alexcrichton merged PR #8610.

Last updated: Nov 22 2024 at 17:03 UTC