Wasmtime GitHub notifications bot (May 13 2024 at 05:00): Wasmtime GitHub notifications bot (May 13 2024 at 05:00):jameysharp requested elliottt for a review on PR #8606.
Wasmtime GitHub notifications bot (May 13 2024 at 05:00):jameysharp requested wasmtime-compiler-reviewers for a review on PR #8606.
Wasmtime GitHub notifications bot (May 13 2024 at 05:00):jameysharp opened PR #8606 from jameysharp:no-lowering-aliases to bytecodealliance:main:
The egraph pass was already doing this, when it ran, and it never adds any aliases. So do it slightly earlier and unconditionally, and avoid needing to resolve any aliases during lowering.
Wasmtime GitHub notifications bot (May 14 2024 at 22:10):elliottt submitted PR review:
Makes sense to me! I interpreted the title of the PR as meaning we would remove aliases later in the pipeline, so I was slightly confused by both the removal from the egraphs pass, and the addition to
optimize. However, the description cleared my questions up :)
Wasmtime GitHub notifications bot (May 15 2024 at 00:42):jameysharp merged PR #8606.
Last updated: Oct 23 2024 at 20:03 UTC