Wasmtime GitHub notifications bot (May 13 2024 at 04:26): Wasmtime GitHub notifications bot (May 13 2024 at 04:26):jameysharp requested elliottt for a review on PR #8605.
Wasmtime GitHub notifications bot (May 13 2024 at 04:26):jameysharp requested wasmtime-compiler-reviewers for a review on PR #8605.
Wasmtime GitHub notifications bot (May 13 2024 at 04:26):jameysharp opened PR #8605 from jameysharp:no-fixed-nonallocatable to bytecodealliance:main:
Consumption of non-allocatable operands was added in #5253 and #5132, and removed in #8524 and following PRs. Now they are not only ignored by regalloc2, but the placeholders that it leaves in the allocation results are also ignored by Cranelift. So let's stop adding them to the operands list entirely.
Wasmtime GitHub notifications bot (May 14 2024 at 22:02):elliottt submitted PR review:
This was surprising to me! However, if we don't ever generate RA2 operands for VRegs that have already been given allocations and we use those existing allocations during instruction emission, we just don't need the fixed-nonallocatable constraints!
Very cool change :)
Wasmtime GitHub notifications bot (May 14 2024 at 22:27):jameysharp merged PR #8605.
Last updated: Dec 23 2024 at 12:05 UTC