Wasmtime GitHub notifications bot (May 12 2024 at 17:10): Wasmtime GitHub notifications bot (May 12 2024 at 17:10):alexcrichton opened PR #8601 from alexcrichton:build-android-binaries to bytecodealliance:main:
This commit is inspired by #6480 and historical asks for Android binaries. This does the bare minimum necessary to configure C compilers such that we can produce binaries but I'll admit that I'm no Android developer myself so I have no idea if these are actually suitable for use anywhere. Otherwise though this build subsumes the preexisting check in CI that the build works for Android, so that part is removed too.
This additionally changes how the NDK is managed from before. Previously a GitHub Action was used to download Java and the NDK and additionally used the
cargo ndksubcommand. That's all removed now in favor of configuring C compilers directly with a pre-installed version of the NDK which should help reduce the CI dependencies a bit.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 12 2024 at 17:10):alexcrichton requested fitzgen for a review on PR #8601.
Wasmtime GitHub notifications bot (May 12 2024 at 17:10):alexcrichton requested wasmtime-default-reviewers for a review on PR #8601.
Wasmtime GitHub notifications bot (May 12 2024 at 20:27):jameysharp submitted PR review:
I worry somebody might think we consider Android a tier 1 platform or something if we start having builds in the releases, but we can navigate that confusion if it happens. I have a couple small suggestions but this seems reasonable to me!
Wasmtime GitHub notifications bot (May 12 2024 at 20:27):jameysharp submitted PR review:
I worry somebody might think we consider Android a tier 1 platform or something if we start having builds in the releases, but we can navigate that confusion if it happens. I have a couple small suggestions but this seems reasonable to me!
Wasmtime GitHub notifications bot (May 12 2024 at 20:27):jameysharp created PR review comment:
This is fine as-is, but what would you think of:
upcase=$(echo $rust | tr a-z- A-Z_)Also, maybe rename
$rustto$target? I was confused about what it had to do with Rust.
Wasmtime GitHub notifications bot (May 13 2024 at 15:05):alexcrichton updated PR #8601.
Wasmtime GitHub notifications bot (May 13 2024 at 15:06):alexcrichton updated PR #8601.
Wasmtime GitHub notifications bot (May 13 2024 at 15:08):alexcrichton commented on PR #8601:
True! I've also updated the tier listing to explicitly say that this is tier 3, like riscv64.
Part of my own motivation here is that I get the impression folks will glance at the release binaries and determine our platform support without digging much further, so this might help give the impression that Wasmtime isn't ONLY windows/mac/linux, perhaps. There's only so much we can do with that level of review from a prospective user though.
Wasmtime GitHub notifications bot (May 13 2024 at 15:08):alexcrichton has enabled auto merge for PR #8601.
Wasmtime GitHub notifications bot (May 13 2024 at 15:47):alexcrichton merged PR #8601.
Last updated: Oct 23 2024 at 20:03 UTC