Wasmtime GitHub notifications bot (May 12 2024 at 00:16): Wasmtime GitHub notifications bot (May 12 2024 at 00:16):alexcrichton requested elliottt for a review on PR #8598.
Wasmtime GitHub notifications bot (May 12 2024 at 00:16):alexcrichton opened PR #8598 from alexcrichton:custom-wast-harness to bytecodealliance:main:
This commit moves testing of
*.wastfiles out of thealltest suite binary and into its own separate binary. The motivation for this is well-described in #4861 with one of the chief reasons being that if the test suite is run and then a new file is added re-running the test suite won't see the file.The
libtest-mimiccrate provides an easy way of regaining most of the features of thelibtestharness such as parallel test execution and filters, meaning that it's pretty easy to switch everything over. The only slightly-tricky bit was redoing the filter for whether a test is ignored or not, but most of the pieces were copied over from the previousbuild.rslogic.Closes #4861
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 12 2024 at 00:16):alexcrichton requested wasmtime-default-reviewers for a review on PR #8598.
Wasmtime GitHub notifications bot (May 12 2024 at 00:16):alexcrichton requested wasmtime-core-reviewers for a review on PR #8598.
Wasmtime GitHub notifications bot (May 12 2024 at 00:41):alexcrichton updated PR #8598.
Wasmtime GitHub notifications bot (May 12 2024 at 20:58):jameysharp submitted PR review:
Oh I am excited for this. Thank you for doing it!
Wasmtime GitHub notifications bot (May 12 2024 at 20:58):jameysharp submitted PR review:
Oh I am excited for this. Thank you for doing it!
Wasmtime GitHub notifications bot (May 12 2024 at 20:58):jameysharp created PR review comment:
If all tests are ignored on miri, can we just avoid constructing any trials in the first place?
Wasmtime GitHub notifications bot (May 12 2024 at 20:58):jameysharp created PR review comment:
What happened to the indentation here? Anyway, can I suggest either using
["references", "tail-call", ...].contains(part)ormatch part { "references" | "tail-call" | ... }, with thestarts_withcases separate?
Wasmtime GitHub notifications bot (May 13 2024 at 15:41):alexcrichton updated PR #8598.
Wasmtime GitHub notifications bot (May 13 2024 at 15:42):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 13 2024 at 15:42):alexcrichton created PR review comment:
Looks like some hard tabs snuck in by accident and rustfmt gives up in comments-interleaved-in-
ifcondition. In any case your suggestion is much better!
Wasmtime GitHub notifications bot (May 13 2024 at 15:42):alexcrichton has enabled auto merge for PR #8598.
Wasmtime GitHub notifications bot (May 13 2024 at 16:21):alexcrichton merged PR #8598.
Last updated: Nov 22 2024 at 16:03 UTC