Wasmtime GitHub notifications bot (May 11 2024 at 22:58): Wasmtime GitHub notifications bot (May 11 2024 at 22:58):alexcrichton opened PR #8597 from alexcrichton:remove-wasmtime-13-cli to bytecodealliance:main:
This commit removes the support in the
wasmtimeCLI for old CLI options which were present in Wasmtime 13 and prior. This compatibility was added in #7385 and backported to the Wasmtime 14 release #7395. Wasmtime 14.0.0, which did not have this compatibility shim, was released on 2023-10-20. Wasmtime 14.0.3, which restored compatibility with this shim, was released on 2023-10-30. This means that Wasmtime since 2023-10-30 has been warning users about differences in the old and new CLI.This commit will be released with Wasmtime 22 which will means that users will have had an 8-month transition window for warnings to migrate. The hope is that this is sufficient but it's also not too too burdensome to carry for longer if necessary.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 11 2024 at 22:58):alexcrichton requested fitzgen for a review on PR #8597.
Wasmtime GitHub notifications bot (May 11 2024 at 22:58):alexcrichton requested wasmtime-core-reviewers for a review on PR #8597.
Wasmtime GitHub notifications bot (May 11 2024 at 22:58):alexcrichton requested wasmtime-default-reviewers for a review on PR #8597.
Wasmtime GitHub notifications bot (May 12 2024 at 21:03):jameysharp commented on PR #8597:
I want to say this is reasonable, but I feel like we should discuss it at the next Wasmtime bi-weekly meeting, at least. I'd also like to find out whether the Go folks have updated yet, for example.
Wasmtime GitHub notifications bot (May 13 2024 at 15:34):alexcrichton commented on PR #8597:
Good point! Added to the agenda
Wasmtime GitHub notifications bot (May 13 2024 at 15:35):alexcrichton commented on PR #8597:
@dgryski or @ydnar do either of y'all have a good sense of whether it's still too soon to remove this support or whether the Go integrations with Wasmtime have been migrated?
Wasmtime GitHub notifications bot (May 23 2024 at 16:36):alexcrichton updated PR #8597.
Wasmtime GitHub notifications bot (May 23 2024 at 16:37):alexcrichton commented on PR #8597:
This was discussed at today's Wasmtime meeting and there were no objections.
Wasmtime GitHub notifications bot (May 23 2024 at 16:37):alexcrichton requested pchickey for a review on PR #8597.
Wasmtime GitHub notifications bot (May 23 2024 at 19:56):pchickey submitted PR review.
Wasmtime GitHub notifications bot (May 23 2024 at 20:21):alexcrichton merged PR #8597.
Last updated: Nov 22 2024 at 16:03 UTC