alexcrichton opened PR #8593 from alexcrichton:read-only-elf
to bytecodealliance:main
:
The latter is what Wasmtime uses today but it pulls in parsers for all object formats supported by
object
. In the context of Wasmtime, however, we know that all objects produced are 64-bit ELF files so there's no need to pull in, for example, a COFF parser as that'll always return an error anyway. This commit switches uses of theobject::File
convenience toElfFile64
instead.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested fitzgen for a review on PR #8593.
alexcrichton requested wasmtime-core-reviewers for a review on PR #8593.
fitzgen submitted PR review:
I think we should be able to disable the default features of
object
and enable just the"elf"
feature now.
fitzgen submitted PR review.
alexcrichton commented on PR #8593:
Ah turns out we're already not-enabling coff/xe/etc, so not much else to do!
alexcrichton merged PR #8593.
Last updated: Dec 23 2024 at 12:05 UTC