Stream: git-wasmtime

Topic: wasmtime / PR #8572 Use WASI builder directly in C API

Wasmtime GitHub notifications bot (May 07 2024 at 14:58):

alexcrichton opened PR #8572 from alexcrichton:update-wasi-c-api to bytecodealliance:main:

This commit updates the C API to use the WasiCtxBuilder directly within wasi_config_t instead of buffering up the options separately. This keeps the behavior of the Rust-based API more similar to the C API and should also help resolve #8552 due to errors being returned more eagerly in the builder-based API.

This additionally makes some minor modifications to the C APIs here as appropriate.

Close #8552

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 07 2024 at 14:58):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8572.

Wasmtime GitHub notifications bot (May 07 2024 at 14:58):

alexcrichton requested elliottt for a review on PR #8572.

Wasmtime GitHub notifications bot (May 07 2024 at 17:28):

whitequark commented on PR #8572:

@alexcrichton Since I've been looking at this PR: do you think you could expose memory stdio in wasmtime-py?

Wasmtime GitHub notifications bot (May 07 2024 at 18:12):

alexcrichton commented on PR #8572:

Sure yeah! Should be simple enough, the functions just didn't exist when I first wrote wasmtime-py

Wasmtime GitHub notifications bot (May 07 2024 at 19:23):

pchickey submitted PR review:

Nice simplification. One minor bug

Wasmtime GitHub notifications bot (May 07 2024 at 19:23):

pchickey submitted PR review:

Nice simplification. One minor bug

Wasmtime GitHub notifications bot (May 07 2024 at 19:23):

pchickey created PR review comment:

I don't think this belongs here

Wasmtime GitHub notifications bot (May 07 2024 at 20:27):

alexcrichton updated PR #8572.

Wasmtime GitHub notifications bot (May 07 2024 at 20:27):

alexcrichton has enabled auto merge for PR #8572.

Wasmtime GitHub notifications bot (May 07 2024 at 21:06):

alexcrichton merged PR #8572.

Last updated: Dec 23 2024 at 12:05 UTC