Wasmtime GitHub notifications bot (May 06 2024 at 19:35): Wasmtime GitHub notifications bot (May 06 2024 at 19:35):lann opened PR #8558 from lann:test-bindgen-outputs to bytecodealliance:main:
These outputs are checked in and verified to be fresh by a test so that they can be relied on for code review.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 06 2024 at 19:35):lann requested alexcrichton for a review on PR #8558.
Wasmtime GitHub notifications bot (May 06 2024 at 19:35):lann requested wasmtime-core-reviewers for a review on PR #8558.
Wasmtime GitHub notifications bot (May 06 2024 at 19:35):lann requested wasmtime-default-reviewers for a review on PR #8558.
Wasmtime GitHub notifications bot (May 06 2024 at 19:47):alexcrichton commented on PR #8558:
Thanks! I think that
cargo vetwill fail on this so mind adding some vets here as well? PR CI isn't detecting it because it's failing since the diff is too large apparently, otherwise this should be showing up in the CI matrix above
Wasmtime GitHub notifications bot (May 06 2024 at 19:57):lann updated PR #8558.
Wasmtime GitHub notifications bot (May 06 2024 at 20:05):lann edited PR #8558:
These outputs are checked in and verified to be fresh by a test so that they can be relied on for code review.
Adds a
stringifyoption tobindgen!which causes the macro to evaluate to a string literal of the generated code instead of actual tokens.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 06 2024 at 20:13):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 07 2024 at 01:23):alexcrichton merged PR #8558.
Last updated: Nov 22 2024 at 17:03 UTC