Stream: git-wasmtime

Topic: wasmtime / PR #8550 wasmtime(gc): Add the `wasmtime::NoEx...

Wasmtime GitHub notifications bot (May 04 2024 at 15:48):

fitzgen requested elliottt for a review on PR #8550.

Wasmtime GitHub notifications bot (May 04 2024 at 15:48):

fitzgen requested wasmtime-core-reviewers for a review on PR #8550.

Wasmtime GitHub notifications bot (May 04 2024 at 15:48):

fitzgen opened PR #8550 from fitzgen:noextern-values to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 04 2024 at 17:15):

alexcrichton submitted PR review:

Apologies if I'm a bit pedantic below, I'm still getting up-to-speed on this I think

Wasmtime GitHub notifications bot (May 04 2024 at 17:15):

alexcrichton submitted PR review:

Apologies if I'm a bit pedantic below, I'm still getting up-to-speed on this I think

Wasmtime GitHub notifications bot (May 04 2024 at 17:15):

alexcrichton created PR review comment:

Mind adding debug asserts self is none and abi is null?

Wasmtime GitHub notifications bot (May 04 2024 at 17:15):

alexcrichton created PR review comment:

This is technically true, right? But can be false due to no GC interactions here?

(if so mind adding a comment here and/or updating the method name?)

Wasmtime GitHub notifications bot (May 04 2024 at 17:15):

alexcrichton created PR review comment:

copy/paste comment?

Wasmtime GitHub notifications bot (May 04 2024 at 17:15):

alexcrichton created PR review comment:

Is this perhaps best modelled as usize? Because technically this is a pointer-sized integer that is a relative offset into the GC heap?

Wasmtime GitHub notifications bot (May 04 2024 at 17:15):

alexcrichton created PR review comment:

Mind matching on self/abi here to avoid the unreachable!?

Wasmtime GitHub notifications bot (May 04 2024 at 17:15):

alexcrichton created PR review comment:

copy/paste for funcref

Wasmtime GitHub notifications bot (May 04 2024 at 17:15):

alexcrichton created PR review comment:

Also I'm a bit confused by the implementation here, shouldn't this be Ok(()) in this case? If the valtype matches then we're guaranteed that the expected/given is the exact same, right?

Wasmtime GitHub notifications bot (May 04 2024 at 18:44):

github-actions[bot] commented on PR #8550:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

• fitzgen: wasmtime:ref-types

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (May 06 2024 at 14:14):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (May 06 2024 at 14:14):

fitzgen created PR review comment:

Yeah this is a copy-paste. This method should be unreachable because there are no concrete heap types in the external type hierarchy that this can be a subtype of.

Wasmtime GitHub notifications bot (May 06 2024 at 14:16):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (May 06 2024 at 14:16):

fitzgen created PR review comment:

Yeah it should be a u32, since if inhabited noextern would be a VMGcRef which is a NonZeroU32 so if we make it optional/nullable we are left with a u32.

Wasmtime GitHub notifications bot (May 06 2024 at 14:44):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (May 06 2024 at 14:44):

fitzgen created PR review comment:

Did some renaming here.

Wasmtime GitHub notifications bot (May 06 2024 at 14:56):

fitzgen updated PR #8550.

Wasmtime GitHub notifications bot (May 06 2024 at 14:56):

fitzgen has enabled auto merge for PR #8550.

Wasmtime GitHub notifications bot (May 06 2024 at 14:58):

fitzgen updated PR #8550.

Wasmtime GitHub notifications bot (May 07 2024 at 15:37):

fitzgen updated PR #8550.

Wasmtime GitHub notifications bot (May 07 2024 at 15:37):

fitzgen has enabled auto merge for PR #8550.

Wasmtime GitHub notifications bot (May 07 2024 at 16:22):

fitzgen updated PR #8550.

Wasmtime GitHub notifications bot (May 07 2024 at 16:22):

fitzgen has enabled auto merge for PR #8550.

Wasmtime GitHub notifications bot (May 07 2024 at 17:03):

fitzgen merged PR #8550.

Last updated: Nov 22 2024 at 17:03 UTC