Stream: git-wasmtime

Topic: wasmtime / PR #8548 `cranelift-frontend`: add and fix var...

Wasmtime GitHub notifications bot (May 04 2024 at 09:44):

tertsdiepraam opened PR #8548 from tertsdiepraam:cranelift-frontend-links to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

While reading through the documentation for cranelift-frontend, I noticed that there were some things that could be converted into links. There were also some links that were spelled out, such as struct.FunctionBuilderContext.html, which is unnecessary and confuses rust-analyzer.

I've tried to fix up all the easy cases that I could find within this crate. Let me know if you want me to split this up over multiple commits or something like that.

Wasmtime GitHub notifications bot (May 04 2024 at 09:44):

tertsdiepraam requested abrown for a review on PR #8548.

Wasmtime GitHub notifications bot (May 04 2024 at 09:44):

tertsdiepraam requested wasmtime-compiler-reviewers for a review on PR #8548.

Wasmtime GitHub notifications bot (May 04 2024 at 10:23):

bjorn3 created PR review comment:

Function derefs to FunctionStencil, so the extra .stencil is not necessary.

Wasmtime GitHub notifications bot (May 04 2024 at 10:23):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (May 04 2024 at 10:39):

tertsdiepraam submitted PR review.

Wasmtime GitHub notifications bot (May 04 2024 at 10:39):

tertsdiepraam created PR review comment:

Alright, I'll remove it!

Wasmtime GitHub notifications bot (May 04 2024 at 10:46):

tertsdiepraam updated PR #8548.

Wasmtime GitHub notifications bot (May 04 2024 at 13:42):

abrown commented on PR #8548:

Looks good to me! Thanks for the changes. Can you amend your commit and add the following somewhere in the doc message so we can trigger the doc build?

protest:full

That way we can see if there's any dead link warnings or the like.

Wasmtime GitHub notifications bot (May 04 2024 at 13:43):

abrown edited a comment on PR #8548:

Looks good to me! Thanks for the changes. Can you amend your commit and add the following somewhere in the doc message so we can trigger the doc build?

prtest:full

That way we can see if there's any dead link warnings or the like.

Wasmtime GitHub notifications bot (May 04 2024 at 13:45):

tertsdiepraam updated PR #8548.

Wasmtime GitHub notifications bot (May 12 2024 at 21:09):

jameysharp submitted PR review:

I agree with @abrown, this all looks good, and it passed the prtest:full CI run so let's merge it. Thank you!

Wasmtime GitHub notifications bot (May 12 2024 at 21:33):

jameysharp merged PR #8548.

Last updated: Dec 23 2024 at 12:05 UTC