Wasmtime GitHub notifications bot (May 03 2024 at 18:47): Wasmtime GitHub notifications bot (May 03 2024 at 18:47):alexcrichton requested cfallin for a review on PR #8544.
Wasmtime GitHub notifications bot (May 03 2024 at 18:47):alexcrichton opened PR #8544 from alexcrichton:fix-cache-and-memory64 to bytecodealliance:main:
This commit fixes a fuzz bug that popped up where the
cache_call_indirectsfeature wasn't reading memory64-based offsets correctly. This is due to (not great) API design inwasmparser(introduced by me) where wasmparser by default won't read 64-bit offsets unless explicitly allowed to. This is to handle how spec tests assert that overlong 32-bit encodings are invalid as the memory64 proposal isn't merged into the spec yet.The fix here is to call
allow_memarg64with whether memory64 is enabled or not and then that'll enable reading these overlong and/or larger offsets correctly.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 03 2024 at 18:47):alexcrichton requested wasmtime-core-reviewers for a review on PR #8544.
Wasmtime GitHub notifications bot (May 03 2024 at 18:47):alexcrichton requested fitzgen for a review on PR #8544.
Wasmtime GitHub notifications bot (May 03 2024 at 18:48):cfallin submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (May 03 2024 at 18:48):cfallin has enabled auto merge for PR #8544.
Wasmtime GitHub notifications bot (May 03 2024 at 19:25):cfallin merged PR #8544.
Last updated: Dec 23 2024 at 12:05 UTC