Stream: git-wasmtime

Topic: wasmtime / PR #8543 Indirect call caching: put options un...

Wasmtime GitHub notifications bot (May 03 2024 at 18:40):

cfallin requested alexcrichton for a review on PR #8543.

Wasmtime GitHub notifications bot (May 03 2024 at 18:40):

cfallin requested wasmtime-core-reviewers for a review on PR #8543.

Wasmtime GitHub notifications bot (May 03 2024 at 18:40):

cfallin opened PR #8543 from cfallin:indirect-call-caching-is-an-optimization-option to bytecodealliance:main:

As per [this comment], the call-indirect caching options should really be in the -O option namespace (for optimizations), not -W (for semantically-visible Wasm standards options); the original PR simply put them in the wrong place, and this PR moves them.

[this comment]: https://github.com/bytecodealliance/wasmtime/pull/8509#discussion_r1589594152

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 03 2024 at 18:48):

alexcrichton submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (May 03 2024 at 18:49):

alexcrichton has enabled auto merge for PR #8543.

Wasmtime GitHub notifications bot (May 03 2024 at 19:19):

alexcrichton merged PR #8543.

Last updated: Dec 23 2024 at 12:05 UTC