Stream: git-wasmtime

Topic: wasmtime / PR #8528 Migrate the `wasmtime-environ` crate ...

Wasmtime GitHub notifications bot (May 02 2024 at 18:34):

alexcrichton requested fitzgen for a review on PR #8528.

Wasmtime GitHub notifications bot (May 02 2024 at 18:34):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8528.

Wasmtime GitHub notifications bot (May 02 2024 at 18:34):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #8528.

Wasmtime GitHub notifications bot (May 02 2024 at 18:34):

alexcrichton requested wasmtime-default-reviewers for a review on PR #8528.

Wasmtime GitHub notifications bot (May 02 2024 at 18:34):

alexcrichton opened PR #8528 from alexcrichton:wasmtime-environ-no-std to bytecodealliance:main:

This commit migrates the wasmtime-environ crate to by default being tagged with #![no_std]. Only the component-model and gc features are able to be built without std, all other features will implicitly activate the std feature as they currently require it one way or another. CI is updated to build wasmtime-environ with these two features active on a no_std platform.

This additionally, for the workspace, disables the std feature for the target-lexicon, indexmap, object, and gimli dependencies. For object/gimli all other crates in the workspace now enable the std feature, but for wasmtime-environ this activation is omitted.

The thiserror dependency was dropped from wasmtime-environ and additionally hashbrown was added for explicit usage of maps.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 02 2024 at 18:35):

alexcrichton updated PR #8528.

Wasmtime GitHub notifications bot (May 02 2024 at 19:11):

alexcrichton updated PR #8528.

Wasmtime GitHub notifications bot (May 02 2024 at 20:24):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (May 02 2024 at 23:52):

alexcrichton merged PR #8528.

Last updated: Nov 22 2024 at 16:03 UTC