Wasmtime GitHub notifications bot (May 02 2024 at 07:06): Wasmtime GitHub notifications bot (May 02 2024 at 07:06):alexcrichton opened PR #8525 from alexcrichton:fix-pooling-allocator-options to bytecodealliance:main:
This commit updates the processing of pooling allocator options in
wasmtime serve. Previously the pooling allocator was enabled by default but the options to configure it weren't processed due to how this default-enable was implemented. The option to enable it by default forwasmtime serve, but onlywasmtime serve, is now processed differently in a way that handles various other
pooling-allocator-related options.Closes #8504
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 02 2024 at 07:06):alexcrichton requested wasmtime-core-reviewers for a review on PR #8525.
Wasmtime GitHub notifications bot (May 02 2024 at 07:06):alexcrichton requested fitzgen for a review on PR #8525.
Wasmtime GitHub notifications bot (May 02 2024 at 11:43):alexcrichton updated PR #8525.
Wasmtime GitHub notifications bot (May 02 2024 at 14:53):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (May 03 2024 at 19:31):alexcrichton updated PR #8525.
Wasmtime GitHub notifications bot (May 03 2024 at 19:33):alexcrichton commented on PR #8525:
I've made the decision to ignore the test I've added here with
#[ignore]. The CI failure shows a bug where we're racing between two events:
- The
wasmtime serveprocess is printing out error information- The test process is running
child.kill()to reap status information as the test is overThere's no way to resolve this race with
wasmtime serveright now as there is no graceful shutdown ofwasmtime serve. I'd like to add that in the future (e.g. ctrl-c waits for all active connections), but that's a bit out of scope for this. In the meantime it still seems good to get a fix in at least.
Wasmtime GitHub notifications bot (May 03 2024 at 19:33):alexcrichton has enabled auto merge for PR #8525.
Wasmtime GitHub notifications bot (May 03 2024 at 20:10):alexcrichton merged PR #8525.
Last updated: Dec 23 2024 at 12:05 UTC